Issue 2135813002: [Merge M52] add experimental param to control the triggering threshold to default Always Translate …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2135813002: [Merge M52] add experimental param to control the triggering threshold to default Always Translate … (Closed)

Created:
4 years, 5 months ago by jungshik at Google

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

[Merge M52] add experimental param to control the triggering threshold to default Always Translate checked BUG=622854 Review-Url: https://codereview.chromium.org/2090283002 Cr-Commit-Position: refs/heads/master@{#403232} (cherry picked from commit 2364a394e98147f92f80ddeb5a1c56abbb547951) Committed: https://chromium.googlesource.com/chromium/src/+/9db11679b5eb2b9a9d5df3a1ae4de65212a3eb84

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -6 lines)			Patch
M	components/translate/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/translate/core/browser/BUILD.gn	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	components/translate/core/browser/translate_prefs.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	components/translate/core/browser/translate_prefs.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/translate/core/browser/translate_ui_delegate.cc	View	3 chunks	+20 lines, -5 lines	0 comments	Download
M	components/translate/core/browser/translate_ui_delegate_unittest.cc	View	2 chunks	+23 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

jungshik at Google

4 years, 5 months ago (2016-07-08 23:36:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9db11679b5eb2b9a9d5df3a1ae4de65212a3eb84.