Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2135803002: DevTools: add Courier New to support monospace arabic on Windows (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add Courier New to support monospace arabic on Windows The current monospace font chain for windows doesn't cover arabic symbols. "Courier New" has all the needed characters, let's fallback to it. BUG=616020 R=alph Committed: https://crrev.com/400443255b3609c9c6d323cb08e083fd767ed39c Cr-Commit-Position: refs/heads/master@{#404558}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 9 (3 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-08 23:08:54 UTC) #1
alph
lgtm https://codereview.chromium.org/2135803002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css (right): https://codereview.chromium.org/2135803002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css#newcode28 third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:28: font-family: Consolas, Lucida Console, Courier New, monospace; should ...
4 years, 5 months ago (2016-07-08 23:11:19 UTC) #3
lushnikov
https://codereview.chromium.org/2135803002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css (right): https://codereview.chromium.org/2135803002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css#newcode28 third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:28: font-family: Consolas, Lucida Console, Courier New, monospace; On 2016/07/08 ...
4 years, 5 months ago (2016-07-08 23:34:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135803002/1
4 years, 5 months ago (2016-07-08 23:34:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-09 01:31:02 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-09 01:32:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/400443255b3609c9c6d323cb08e083fd767ed39c
Cr-Commit-Position: refs/heads/master@{#404558}

Powered by Google App Engine
This is Rietveld 408576698