Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2135783003: Blink: Remove special HTMLPlugInElement logic for QuickTime. (Closed)

Created:
4 years, 5 months ago by tommycli
Modified:
4 years, 5 months ago
Reviewers:
jbroman
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink: Remove special HTMLPlugInElement logic for QuickTime. QuickTime hasn't been a Chrome plugin since NPAPI deprecation - or even longer. We no longer need special-case logic for TIFFs and QuickTime. BUG=NONE R=jbroman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d5bb963cb5ce55b926b6464eefc071b1f8874ed8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
tommycli
jbroman: PTAL cleanup CL
4 years, 5 months ago (2016-07-08 23:52:24 UTC) #3
jbroman
lgtm
4 years, 5 months ago (2016-07-09 19:26:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135783003/1
4 years, 5 months ago (2016-07-11 20:39:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253304)
4 years, 5 months ago (2016-07-11 23:21:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135783003/1
4 years, 5 months ago (2016-07-11 23:24:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190567)
4 years, 5 months ago (2016-07-12 02:35:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135783003/1
4 years, 5 months ago (2016-07-12 14:39:21 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191450)
4 years, 5 months ago (2016-07-12 18:45:32 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d5bb963cb5ce55b926b6464eefc071b1f8874ed8 Cr-Commit-Position: refs/heads/master@{#404818}
4 years, 5 months ago (2016-07-12 18:51:47 UTC) #18
tommycli
4 years, 5 months ago (2016-07-12 18:52:52 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5bb963cb5ce55b926b6464eefc071b1f8874ed8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698