|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by tommycli Modified:
4 years, 5 months ago Reviewers:
jbroman CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBlink: Remove special HTMLPlugInElement logic for QuickTime.
QuickTime hasn't been a Chrome plugin since NPAPI deprecation - or even
longer. We no longer need special-case logic for TIFFs and QuickTime.
BUG=NONE
R=jbroman@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/d5bb963cb5ce55b926b6464eefc071b1f8874ed8
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Blink: Remove special HTMLPlugInElement logic for QuickTime. QuickTime hasn't been a Chrome plugin since NPAPI deprecation - or even longer. We no longer need special-case logic for TIFFs and QuickTime. BUG=NONE ========== to ========== Blink: Remove special HTMLPlugInElement logic for QuickTime. QuickTime hasn't been a Chrome plugin since NPAPI deprecation - or even longer. We no longer need special-case logic for TIFFs and QuickTime. BUG=NONE ==========
tommycli@chromium.org changed reviewers: + jbroman@chromium.org
jbroman: PTAL cleanup CL
lgtm
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Message was sent while issue was closed.
Description was changed from ========== Blink: Remove special HTMLPlugInElement logic for QuickTime. QuickTime hasn't been a Chrome plugin since NPAPI deprecation - or even longer. We no longer need special-case logic for TIFFs and QuickTime. BUG=NONE ========== to ========== Blink: Remove special HTMLPlugInElement logic for QuickTime. QuickTime hasn't been a Chrome plugin since NPAPI deprecation - or even longer. We no longer need special-case logic for TIFFs and QuickTime. BUG=NONE R=jbroman@chromium.org Committed: https://crrev.com/d5bb963cb5ce55b926b6464eefc071b1f8874ed8 Cr-Commit-Position: refs/heads/master@{#404818} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d5bb963cb5ce55b926b6464eefc071b1f8874ed8 Cr-Commit-Position: refs/heads/master@{#404818}
Message was sent while issue was closed.
Description was changed from ========== Blink: Remove special HTMLPlugInElement logic for QuickTime. QuickTime hasn't been a Chrome plugin since NPAPI deprecation - or even longer. We no longer need special-case logic for TIFFs and QuickTime. BUG=NONE R=jbroman@chromium.org Committed: https://crrev.com/d5bb963cb5ce55b926b6464eefc071b1f8874ed8 Cr-Commit-Position: refs/heads/master@{#404818} ========== to ========== Blink: Remove special HTMLPlugInElement logic for QuickTime. QuickTime hasn't been a Chrome plugin since NPAPI deprecation - or even longer. We no longer need special-case logic for TIFFs and QuickTime. BUG=NONE R=jbroman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d5bb963cb5ce55b926b6464eefc0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as d5bb963cb5ce55b926b6464eefc071b1f8874ed8 (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
