Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2135743002: Adds command line switch to disable resize lock (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds command line switch to disable resize lock The resize lock completely throws off tests that generate events. These tests aren't meant to exercise the resize lock, so disabling seems reasonable. This is just the plumbing for the disable, will start enabling tests separately. BUG=331924 TEST=none R=piman@chromium.org Committed: https://crrev.com/d75fb6b60d4e6a23f5aa2d43e08f471b57d68d0b Cr-Commit-Position: refs/heads/master@{#404485}

Patch Set 1 #

Total comments: 2

Patch Set 2 : disable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/renderer_host/delegated_frame_host.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sky
4 years, 5 months ago (2016-07-08 17:28:39 UTC) #1
piman
https://codereview.chromium.org/2135743002/diff/1/content/browser/renderer_host/delegated_frame_host.cc File content/browser/renderer_host/delegated_frame_host.cc (right): https://codereview.chromium.org/2135743002/diff/1/content/browser/renderer_host/delegated_frame_host.cc#newcode127 content/browser/renderer_host/delegated_frame_host.cc:127: switches::kEnableResizeLock) == "true"; Do you want instead do a ...
4 years, 5 months ago (2016-07-08 18:42:44 UTC) #2
sky
https://codereview.chromium.org/2135743002/diff/1/content/browser/renderer_host/delegated_frame_host.cc File content/browser/renderer_host/delegated_frame_host.cc (right): https://codereview.chromium.org/2135743002/diff/1/content/browser/renderer_host/delegated_frame_host.cc#newcode127 content/browser/renderer_host/delegated_frame_host.cc:127: switches::kEnableResizeLock) == "true"; On 2016/07/08 18:42:44, piman wrote: > ...
4 years, 5 months ago (2016-07-08 19:16:53 UTC) #3
piman
lgtm
4 years, 5 months ago (2016-07-08 19:31:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135743002/20001
4 years, 5 months ago (2016-07-08 19:37:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 21:08:11 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:10:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d75fb6b60d4e6a23f5aa2d43e08f471b57d68d0b
Cr-Commit-Position: refs/heads/master@{#404485}

Powered by Google App Engine
This is Rietveld 408576698