Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 21357003: Stores to external references don't need write barriers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3924 matching lines...) Expand 10 before | Expand all | Expand 10 after
3935 } 3935 }
3936 3936
3937 3937
3938 void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) { 3938 void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {
3939 Representation representation = instr->representation(); 3939 Representation representation = instr->representation();
3940 3940
3941 HObjectAccess access = instr->hydrogen()->access(); 3941 HObjectAccess access = instr->hydrogen()->access();
3942 int offset = access.offset(); 3942 int offset = access.offset();
3943 3943
3944 if (access.IsExternalMemory()) { 3944 if (access.IsExternalMemory()) {
3945 ASSERT(!instr->hydrogen()->NeedsWriteBarrier());
3945 Register value = ToRegister(instr->value()); 3946 Register value = ToRegister(instr->value());
3946 if (instr->object()->IsConstantOperand()) { 3947 if (instr->object()->IsConstantOperand()) {
3947 ASSERT(value.is(rax)); 3948 ASSERT(value.is(rax));
3948 LConstantOperand* object = LConstantOperand::cast(instr->object()); 3949 LConstantOperand* object = LConstantOperand::cast(instr->object());
3949 __ store_rax(ToExternalReference(object)); 3950 __ store_rax(ToExternalReference(object));
3950 } else { 3951 } else {
3951 Register object = ToRegister(instr->object()); 3952 Register object = ToRegister(instr->object());
3952 __ movq(MemOperand(object, offset), value); 3953 __ movq(MemOperand(object, offset), value);
3953 } 3954 }
3954 return; 3955 return;
(...skipping 1610 matching lines...) Expand 10 before | Expand all | Expand 10 after
5565 FixedArray::kHeaderSize - kPointerSize)); 5566 FixedArray::kHeaderSize - kPointerSize));
5566 __ bind(&done); 5567 __ bind(&done);
5567 } 5568 }
5568 5569
5569 5570
5570 #undef __ 5571 #undef __
5571 5572
5572 } } // namespace v8::internal 5573 } } // namespace v8::internal
5573 5574
5574 #endif // V8_TARGET_ARCH_X64 5575 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698