Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 21357003: Stores to external references don't need write barriers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/ia32/lithium-ia32.cc ('K') | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2219 matching lines...) Expand 10 before | Expand all | Expand 10 after
2230 2230
2231 LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 2231 LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {
2232 bool is_in_object = instr->access().IsInobject(); 2232 bool is_in_object = instr->access().IsInobject();
2233 bool is_external_location = instr->access().IsExternalMemory() && 2233 bool is_external_location = instr->access().IsExternalMemory() &&
2234 instr->access().offset() == 0; 2234 instr->access().offset() == 0;
2235 bool needs_write_barrier = instr->NeedsWriteBarrier(); 2235 bool needs_write_barrier = instr->NeedsWriteBarrier();
2236 bool needs_write_barrier_for_map = !instr->transition().is_null() && 2236 bool needs_write_barrier_for_map = !instr->transition().is_null() &&
2237 instr->NeedsWriteBarrierForMap(); 2237 instr->NeedsWriteBarrierForMap();
2238 2238
2239 LOperand* obj; 2239 LOperand* obj;
2240 if (needs_write_barrier) { 2240 if (is_external_location) {
2241 obj = is_in_object
2242 ? UseRegister(instr->object())
2243 : UseTempRegister(instr->object());
2244 } else if (is_external_location) {
2245 ASSERT(!is_in_object); 2241 ASSERT(!is_in_object);
2246 ASSERT(!needs_write_barrier); 2242 ASSERT(!needs_write_barrier);
2247 ASSERT(!needs_write_barrier_for_map); 2243 ASSERT(!needs_write_barrier_for_map);
2248 obj = UseRegisterOrConstant(instr->object()); 2244 obj = UseRegisterOrConstant(instr->object());
2245 } else if (needs_write_barrier) {
2246 obj = is_in_object
2247 ? UseRegister(instr->object())
2248 : UseTempRegister(instr->object());
2249 } else { 2249 } else {
2250 obj = needs_write_barrier_for_map 2250 obj = needs_write_barrier_for_map
2251 ? UseRegister(instr->object()) 2251 ? UseRegister(instr->object())
2252 : UseRegisterAtStart(instr->object()); 2252 : UseRegisterAtStart(instr->object());
2253 } 2253 }
2254 2254
2255 bool can_be_constant = instr->value()->IsConstant() && 2255 bool can_be_constant = instr->value()->IsConstant() &&
2256 HConstant::cast(instr->value())->NotInNewSpace() && 2256 HConstant::cast(instr->value())->NotInNewSpace() &&
2257 !(FLAG_track_double_fields && instr->field_representation().IsDouble()); 2257 !(FLAG_track_double_fields && instr->field_representation().IsDouble());
2258 2258
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
2544 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2544 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2545 LOperand* object = UseRegister(instr->object()); 2545 LOperand* object = UseRegister(instr->object());
2546 LOperand* index = UseTempRegister(instr->index()); 2546 LOperand* index = UseTempRegister(instr->index());
2547 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2547 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2548 } 2548 }
2549 2549
2550 2550
2551 } } // namespace v8::internal 2551 } } // namespace v8::internal
2552 2552
2553 #endif // V8_TARGET_ARCH_X64 2553 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/ia32/lithium-ia32.cc ('K') | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698