[wasm] Add a BytecodeIterator and use in non-performance-critical situations.

[wasm] Add a BytecodeIterator and use in non-performance-critical situations.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/9be74f6687df4b2fb55972bc8e2d9a5117b40c7a
Cr-Commit-Position: refs/heads/master@{#37642}

[ahaas, 2016-07-08 14:08:30]

On 2016/07/08 at 14:00:36, titzer wrote:
> 

Would it be worth to implement the std::iterator interface here, as the gc
people were doing in https://codereview.chromium.org/2088223002/ ?

[titzer, 2016-07-11 11:45:59]

On 2016/07/08 14:08:30, ahaas wrote:
> On 2016/07/08 at 14:00:36, titzer wrote:
> > 
> 
> Would it be worth to implement the std::iterator interface here, as the gc
> people were doing in https://codereview.chromium.org/2088223002/ ?

IMO no, but I added it anyway, and some tests.

Most situations also need the pc_offset(), which is hard to support in the C++
iterator protocol.
I've added the convenience for foreach, though.

[ahaas, 2016-07-11 12:31:19]

lgtm

https://codereview.chromium.org/2135693002/diff/20001/test/unittests/wasm/ast...
File test/unittests/wasm/ast-decoder-unittest.cc (right):

https://codereview.chromium.org/2135693002/diff/20001/test/unittests/wasm/ast...
test/unittests/wasm/ast-decoder-unittest.cc:2450: EXPECT_TRUE(false);
why don't you say 
EXPECT_TRUE(pos < arraysize(expected));?

[titzer, 2016-07-11 12:34:00]

On 2016/07/11 12:31:19, ahaas wrote:
> lgtm
> 
>
https://codereview.chromium.org/2135693002/diff/20001/test/unittests/wasm/ast...
> File test/unittests/wasm/ast-decoder-unittest.cc (right):
> 
>
https://codereview.chromium.org/2135693002/diff/20001/test/unittests/wasm/ast...
> test/unittests/wasm/ast-decoder-unittest.cc:2450: EXPECT_TRUE(false);
> why don't you say 
> EXPECT_TRUE(pos < arraysize(expected));?

Did that first :) Because EXPECT's keep going, even when they fail.

[titzer, 2016-07-11 12:34:05]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-07-11 12:34:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 12:57:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-11 12:57:28]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 13:00:34]

Description was changed from

==========
[wasm] Add a BytecodeIterator and use in non-performance-critical situations.

R=ahaas@chromium.org
BUG=
==========

to

==========
[wasm] Add a BytecodeIterator and use in non-performance-critical situations.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/9be74f6687df4b2fb55972bc8e2d9a5117b40c7a
Cr-Commit-Position: refs/heads/master@{#37642}
==========

[commit-bot: I haz the power, 2016-07-11 13:00:35]

Patchset 2 (id:??) landed as
https://crrev.com/9be74f6687df4b2fb55972bc8e2d9a5117b40c7a
Cr-Commit-Position: refs/heads/master@{#37642}