Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 2135683002: Do not reload when we are evaluating a constant expression during compilation (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not reload when we are evaluating a constants during compilation - [x] Add a NoReloadScope to `Parser::RunStaticFieldInitializer` - [x] Add a NoReloadScope to `Parser::EvaluateConstConstructorCall` - [x] Add a NoReloadScope to `Parser::Interpolate` - [x] Add a NoReloadScope to `Parser::EvaluateConstExpr` Fixes #26837 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/4ef89ec4e916ab4d25c908e9bb51aa587396b270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/parser.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 5 months ago (2016-07-08 13:47:24 UTC) #4
Florian Schneider
lgtm
4 years, 5 months ago (2016-07-08 17:03:28 UTC) #5
Cutch
4 years, 5 months ago (2016-07-08 17:05:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ef89ec4e916ab4d25c908e9bb51aa587396b270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698