Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2135653002:
Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://coder… (Closed)
|
Created:
4 years, 5 months ago by primiano CORP (USE chromium) Modified:
4 years, 5 months ago CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPartial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ )
This is a partial revert of https://codereview.chromium.org/2131933002/.
A git bisect ultimately identified this as the cultprit of the
windows bots breakage (crbug.com/626539).
The reasons of the breakage are obscure to me, but this change seems to
cause a linker error in the windows bots while building blacklist_test_main_dll
as follows:
FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb
allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005:
__query_new_mode already defined in libucrt.lib(new_mode.obj)
allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005:
__set_new_mode already defined in libucrt.lib(new_mode.obj)
allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc
already defined in libucrt.lib(calloc.obj)
allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free
already defined in libucrt.lib(free.obj)
allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc
already defined in libucrt.lib(malloc.obj)
blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply
defined symbols found
Landing to unblock the windows bots.
BUG=626539
TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true
Committed: https://crrev.com/b0dda462afbc57e7ba583a6c7194278d9a2075d2
Cr-Commit-Position: refs/heads/master@{#404343}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found BUG=None ========== to ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found BUG=None CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
Description was changed from ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found BUG=None CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=None TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org ==========
primiano@chromium.org changed reviewers: + cpu@chromium.org, wfh@chromium.org
On 2016/07/08 13:13:42, primiano CORP (USE chromium) wrote: > Description was changed from > > ========== > Partial Revert of Replace string::find(prefix) == 0 pattern with > base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) > > This is a partial revert of https://codereview.chromium.org/2131933002/. > A git bisect ultimately identified this as the cultprit of the breakage. > For reasons that are obscure to me, this change seems to cause a > linker error in the windows bots while building blacklist_test_main_dll > as follows: > FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib > blacklist_test_main_dll.dll.pdb > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: > __query_new_mode already defined in libucrt.lib(new_mode.obj) > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: > __set_new_mode already defined in libucrt.lib(new_mode.obj) > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc > already defined in libucrt.lib(calloc.obj) > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free > already defined in libucrt.lib(free.obj) > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc > already defined in libucrt.lib(malloc.obj) > > blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply > defined symbols found > > BUG=None > ========== > > to > > ========== > Partial Revert of Replace string::find(prefix) == 0 pattern with > base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) > > This is a partial revert of https://codereview.chromium.org/2131933002/. > A git bisect ultimately identified this as the cultprit of the breakage. > For reasons that are obscure to me, this change seems to cause a > linker error in the windows bots while building blacklist_test_main_dll > as follows: > FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib > blacklist_test_main_dll.dll.pdb > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: > __query_new_mode already defined in libucrt.lib(new_mode.obj) > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: > __set_new_mode already defined in libucrt.lib(new_mode.obj) > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc > already defined in libucrt.lib(calloc.obj) > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free > already defined in libucrt.lib(free.obj) > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc > already defined in libucrt.lib(malloc.obj) > > blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply > defined symbols found > > BUG=None > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng > ========== LGTM
Description was changed from ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=None TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org ========== to ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org ==========
On 2016/07/08 13:15:05, markusheintz_ wrote: > On 2016/07/08 13:13:42, primiano CORP (USE chromium) wrote: > > Description was changed from > > > > ========== > > Partial Revert of Replace string::find(prefix) == 0 pattern with > > base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) > > > > This is a partial revert of https://codereview.chromium.org/2131933002/. > > A git bisect ultimately identified this as the cultprit of the breakage. > > For reasons that are obscure to me, this change seems to cause a > > linker error in the windows bots while building blacklist_test_main_dll > > as follows: > > FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib > > blacklist_test_main_dll.dll.pdb > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: > > __query_new_mode already defined in libucrt.lib(new_mode.obj) > > > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: > > __set_new_mode already defined in libucrt.lib(new_mode.obj) > > > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc > > already defined in libucrt.lib(calloc.obj) > > > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free > > already defined in libucrt.lib(free.obj) > > > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc > > already defined in libucrt.lib(malloc.obj) > > > > blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply > > defined symbols found > > > > BUG=None > > ========== > > > > to > > > > ========== > > Partial Revert of Replace string::find(prefix) == 0 pattern with > > base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) > > > > This is a partial revert of https://codereview.chromium.org/2131933002/. > > A git bisect ultimately identified this as the cultprit of the breakage. > > For reasons that are obscure to me, this change seems to cause a > > linker error in the windows bots while building blacklist_test_main_dll > > as follows: > > FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib > > blacklist_test_main_dll.dll.pdb > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: > > __query_new_mode already defined in libucrt.lib(new_mode.obj) > > > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: > > __set_new_mode already defined in libucrt.lib(new_mode.obj) > > > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc > > already defined in libucrt.lib(calloc.obj) > > > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free > > already defined in libucrt.lib(free.obj) > > > > allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc > > already defined in libucrt.lib(malloc.obj) > > > > blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply > > defined symbols found > > > > BUG=None > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng > > ========== > > LGTM Wanne add https://bugs.chromium.org/p/chromium/issues/detail?id=626539
Description was changed from ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org ========== to ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true ==========
Description was changed from ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true ========== to ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ==========
Description was changed from ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the breakage. For reasons that are obscure to me, this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ========== to ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the windows bots breakage (crbug.com/626539). The reasons of the breakage are obscure to me, but this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ==========
The CQ bit was checked by primiano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the windows bots breakage (crbug.com/626539). The reasons of the breakage are obscure to me, but this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ========== to ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the windows bots breakage (crbug.com/626539). The reasons of the breakage are obscure to me, but this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the windows bots breakage (crbug.com/626539). The reasons of the breakage are obscure to me, but this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ========== to ========== Partial Revert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (https://codereview.chromium.org/2121513002/ ) This is a partial revert of https://codereview.chromium.org/2131933002/. A git bisect ultimately identified this as the cultprit of the windows bots breakage (crbug.com/626539). The reasons of the breakage are obscure to me, but this change seems to cause a linker error in the windows bots while building blacklist_test_main_dll as follows: FAILED: blacklist_test_main_dll.dll blacklist_test_main_dll.dll.lib blacklist_test_main_dll.dll.pdb allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __query_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: __set_new_mode already defined in libucrt.lib(new_mode.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _calloc already defined in libucrt.lib(calloc.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _free already defined in libucrt.lib(free.obj) allocator.lib(allocator.allocator_shim_win.obj) : error LNK2005: _malloc already defined in libucrt.lib(malloc.obj) blacklist_test_main_dll.dll : fatal error LNK1169: one or more multiply defined symbols found Landing to unblock the windows bots. BUG=626539 TBR=cpu@chromium.org,thestig@chromium.org,lazyboy@chromium.org,wfh@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true Committed: https://crrev.com/b0dda462afbc57e7ba583a6c7194278d9a2075d2 Cr-Commit-Position: refs/heads/master@{#404343} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b0dda462afbc57e7ba583a6c7194278d9a2075d2 Cr-Commit-Position: refs/heads/master@{#404343} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
