Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2135633002: Moving assert_throws test cases under generate_tests. (Closed)

Created:
4 years, 5 months ago by pals
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving assert_throws test cases under generate_tests. BUG=587995 Committed: https://crrev.com/37cd2dda7f0314e45cc242ecc07836a3e711cb6e Cr-Commit-Position: refs/heads/master@{#404412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -48 lines) Patch
M third_party/WebKit/LayoutTests/payments/payment-request-interface.html View 2 chunks +24 lines, -48 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
pals
PTAL.
4 years, 5 months ago (2016-07-08 13:25:02 UTC) #3
please use gerrit instead
lgtm
4 years, 5 months ago (2016-07-08 13:55:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135633002/1
4 years, 5 months ago (2016-07-08 16:36:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 16:46:30 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 16:46:39 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 16:49:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37cd2dda7f0314e45cc242ecc07836a3e711cb6e
Cr-Commit-Position: refs/heads/master@{#404412}

Powered by Google App Engine
This is Rietveld 408576698