Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 213563002: Remove PlatformFile from webrtc_log_uploader (Closed)

Created:
6 years, 9 months ago by rvargas (doing something else)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Remove PlatformFile from webrtc_log_uploader BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260442

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M chrome/browser/media/webrtc_log_uploader_unittest.cc View 1 2 chunks +14 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
rvargas (doing something else)
PTAL
6 years, 9 months ago (2014-03-27 22:45:50 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 9 months ago (2014-03-27 23:33:22 UTC) #2
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 9 months ago (2014-03-27 23:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/213563002/20001
6 years, 9 months ago (2014-03-27 23:34:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 01:28:48 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289977
6 years, 9 months ago (2014-03-28 01:28:49 UTC) #6
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 9 months ago (2014-03-28 01:31:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/213563002/20001
6 years, 9 months ago (2014-03-28 01:33:19 UTC) #8
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:40:51 UTC) #9
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:43:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/213563002/20001
6 years, 8 months ago (2014-03-30 16:43:16 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:20:23 UTC) #12
Message was sent while issue was closed. 
Change committed as 260442

Powered by Google App Engine
This is Rietveld 408576698