Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2135603003: Make MockOptions a thin wrapper around optparse.Values. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MockOptions a thin wrapper around optparse.Values. BUG=626679 Committed: https://crrev.com/a400412a7ef4a612e7391a294112cabad3e30c37 Cr-Commit-Position: refs/heads/master@{#408175}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -76 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py View 1 2 1 chunk +6 lines, -18 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool_unittest.py View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
qyearsley
4 years, 5 months ago (2016-07-08 18:04:06 UTC) #2
qyearsley
Ping - this is a non-urgent but relatively small CL. (Purpose of the CL is ...
4 years, 5 months ago (2016-07-25 20:58:48 UTC) #7
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-25 21:59:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135603003/1
4 years, 5 months ago (2016-07-26 03:07:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/41165) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-26 03:08:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135603003/20001
4 years, 5 months ago (2016-07-26 04:19:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/41199) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-26 04:20:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135603003/60001
4 years, 4 months ago (2016-07-27 16:35:11 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-27 17:46:08 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:47:48 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a400412a7ef4a612e7391a294112cabad3e30c37
Cr-Commit-Position: refs/heads/master@{#408175}

Powered by Google App Engine
This is Rietveld 408576698