Chromium Code Reviews

Issue 2135593002: Enable visibility and security checks for builtin exit frames (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable visibility and security checks for builtin exit frames Enable the same checks for builtin exit frames as are used for all other standard (i.e. non-wasm) types, and refactor them into a single helper class. R=yangguo@chromium.org BUG= Committed: https://crrev.com/59705072ad4be7601f7ad0b061b48aca2eeeb1d8 Cr-Commit-Position: refs/heads/master@{#37625}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+87 lines, -51 lines)
M src/isolate.cc View 6 chunks +87 lines, -51 lines 0 comments

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135593002/1
4 years, 5 months ago (2016-07-08 10:03:01 UTC) #2
jgruber
4 years, 5 months ago (2016-07-08 10:03:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19079)
4 years, 5 months ago (2016-07-08 10:08:32 UTC) #5
Yang
On 2016/07/08 10:08:32, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 5 months ago (2016-07-08 10:37:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135593002/1
4 years, 5 months ago (2016-07-11 07:24:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 07:48:23 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 07:50:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59705072ad4be7601f7ad0b061b48aca2eeeb1d8
Cr-Commit-Position: refs/heads/master@{#37625}

Powered by Google App Engine