Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2135573003: [Simd128] Add CpuFeatures::SupportsSimd128 method. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Simd128] Add CpuFeatures::SupportsSimd128 method. All architectures return false for now. LOG=N BUG=v8:4124 Committed: https://crrev.com/f797c4b889ff369d65f71b66c975efc2a521a15c Cr-Commit-Position: refs/heads/master@{#37649}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/arm/assembler-arm-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/assembler-s390-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bbudge
4 years, 5 months ago (2016-07-08 16:19:02 UTC) #2
Benedikt Meurer
Thanks Bill, LGTM. Sorry for the delay.
4 years, 5 months ago (2016-07-09 17:53:16 UTC) #3
bbudge
On 2016/07/09 17:53:16, Benedikt Meurer wrote: > Thanks Bill, LGTM. Sorry for the delay. Hey, ...
4 years, 5 months ago (2016-07-09 19:58:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135573003/20001
4 years, 5 months ago (2016-07-11 14:59:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 15:32:40 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 15:36:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f797c4b889ff369d65f71b66c975efc2a521a15c
Cr-Commit-Position: refs/heads/master@{#37649}

Powered by Google App Engine
This is Rietveld 408576698