Address compilation warnings for android build.

src/parsing/scanner.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Features shared by parsing and pre-parsing scanners.
 
 #ifndef V8_PARSING_SCANNER_H_
 #define V8_PARSING_SCANNER_H_
 
 #include "src/allocation.h"
@@ skipping 144 matching lines @@
 
 class LiteralBuffer {
  public:
   LiteralBuffer() : is_one_byte_(true), position_(0), backing_store_() { }
 
   ~LiteralBuffer() { backing_store_.Dispose(); }
 
   INLINE(void AddChar(char code_unit)) {
     if (position_ >= backing_store_.length()) ExpandBuffer();
     DCHECK(is_one_byte_);
-    DCHECK(0 <= code_unit && code_unit <= kMaxAscii);
+    DCHECK(iscntrl(code_unit) || isprint(code_unit));

[vogelheim, 2016/07/11 07:42:49]

Hrm. I searched for several minutes until I had found suitable defintions for
iscntrl and isprint, so I could determine whether this is correct. The good news
is, of course it's correct.

The bad news is, it took me quite a bit to figure that out.

Can we have a warning-free version that just checks upper & lower bounds?

     backing_store_[position_] = static_cast<byte>(code_unit);
     position_ += kOneByteSize;
     return;
   }
 
   INLINE(void AddChar(uc32 code_unit)) {
     if (position_ >= backing_store_.length()) ExpandBuffer();
     if (is_one_byte_) {
       if (code_unit <= unibrow::Latin1::kMaxChar) {
         backing_store_[position_] = static_cast<byte>(code_unit);
@@ skipping 646 matching lines @@
   bool allow_harmony_exponentiation_operator_;
 
   MessageTemplate::Template scanner_error_;
   Location scanner_error_location_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_PARSING_SCANNER_H_