Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2135503002: Narrowly address async function stack overflow parsing case (Closed)

Created:
4 years, 5 months ago by Dan Ehrenberg
Modified:
4 years, 5 months ago
Reviewers:
caitp (gmail), caitp, neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Narrowly address async function stack overflow parsing case This patch just checks for a stack overflow and returns failure from the cases which Clusterfuzz found. However, there may be more locations in the parser which need similar treatment. R=caitpotter88@gmail.com,neis BUG=v8:4483, chromium:624300 Committed: https://crrev.com/77cbe27689d3c8823ea492cbc33f7718a4b5e417 Cr-Commit-Position: refs/heads/master@{#37655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/parsing/parser.cc View 1 chunk +8 lines, -2 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-624300.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135503002/1
4 years, 5 months ago (2016-07-08 00:45:29 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-08 01:38:55 UTC) #4
Dan Ehrenberg
PTAL
4 years, 5 months ago (2016-07-08 19:13:12 UTC) #5
caitp
On 2016/07/08 19:13:12, Dan Ehrenberg wrote: > PTAL lgtm.
4 years, 5 months ago (2016-07-08 19:37:54 UTC) #6
neis
lgtm. yes, we should check if there are other such places and fix them, preferably ...
4 years, 5 months ago (2016-07-11 10:00:33 UTC) #7
Dan Ehrenberg
No, it seems like this is a general issue.
4 years, 5 months ago (2016-07-11 19:03:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135503002/1
4 years, 5 months ago (2016-07-11 19:04:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 19:29:06 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 19:33:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77cbe27689d3c8823ea492cbc33f7718a4b5e417
Cr-Commit-Position: refs/heads/master@{#37655}

Powered by Google App Engine
This is Rietveld 408576698