[Downloads] Move client guid for AV scanning of downloaded files to chrome/

content/browser/download/download_file_impl.h

Index: content/browser/download/download_file_impl.h
diff --git a/content/browser/download/download_file_impl.h b/content/browser/download/download_file_impl.h
index 963ae9fc58f3b9cf8b694e580cedaf2d6ea34b00..be484621f6aa962fb7c69f4b801378d9cc0ce360 100644
--- a/content/browser/download/download_file_impl.h
+++ b/content/browser/download/download_file_impl.h
@@ -64,6 +64,11 @@ class CONTENT_EXPORT DownloadFileImpl : virtual public DownloadFile {
   virtual bool GetHash(std::string* hash) OVERRIDE;
   virtual std::string GetHashState() OVERRIDE;
 
+  // Set the application GUID to be used to identify the app to the
+  // system AV function when scanning downloaded files. Should be called
+  // before RenameAndAnnotate() to take effect.
+  virtual void SetClientGuid(const std::string& guid) OVERRIDE;

[asanka, 2013/08/07 16:42:36]

Could you remind me why a SetClientGuid() method was added instead of adding a
parameter to the constructor?

[Greg Billock, 2013/08/07 17:42:56]

I went that route at first. It quickly explodes, though -- the SaveFile needs
one, and DownloadFileImpl, and then of course an arg to the factory, and all of
the associated tests, mocks, subclasses, etc. It ends up being an invasive
change across like 20-25 files which mainly introduces noise.

There's a lot to like about it, but I ended up concluding that this narrow use
was OK to have a setter.

+
  protected:
   // For test class overrides.
   virtual DownloadInterruptReason AppendDataToFile(