content/browser/browser_thread_impl.cc - Issue 2135413003: Add |joinable| to Thread::Options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_thread_impl.cc

Issue 2135413003: Add |joinable| to Thread::Options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ignore SetMessageLoop(nullptr) for now -- added TODO Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_thread_impl.cc

diff --git a/content/browser/browser_thread_impl.cc b/content/browser/browser_thread_impl.cc

index cc5b9d00428c06c64e89675609321535fbc0e121..a3a33bdea5ecf490df43495f4cba190c0695ff41 100644

--- a/content/browser/browser_thread_impl.cc

+++ b/content/browser/browser_thread_impl.cc

@@ -152,7 +152,7 @@ BrowserThreadImpl::BrowserThreadImpl(ID identifier)

BrowserThreadImpl::BrowserThreadImpl(ID identifier,

base::MessageLoop* message_loop)

: Thread(GetThreadName(identifier)), identifier_(identifier) {

- set_message_loop(message_loop);

+ SetMessageLoop(message_loop);

Initialize();

// If constructed with an explicit message loop, this is a fake BrowserThread

« no previous file with comments | « base/threading/thread_unittest.cc ('k') | ios/web/web_thread_impl.cc » ('j') | no next file with comments »