src/IceInstX86BaseImpl.h - Issue 2135403002: Subzero: Aggressive LEA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX86BaseImpl.h

Issue 2135403002: Subzero: Aggressive LEA (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Put duplicate logic into protected method Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceInstX86BaseImpl.h

diff --git a/src/IceInstX86BaseImpl.h b/src/IceInstX86BaseImpl.h

index cfc36d44a4fb3827d3329385015dc6de47a9631b..f5732cb974a8bf511ec0012a09334f2a191230c3 100644

--- a/src/IceInstX86BaseImpl.h

+++ b/src/IceInstX86BaseImpl.h

@@ -2025,6 +2025,12 @@ template <typename TraitsType>

void InstImpl<TraitsType>::InstX86Lea::emit(const Cfg *Func) const {

if (!BuildDefs::dump())

return;

+ if (auto *Add =

+ InstX86BaseUnaryopGPR<InstX86Base::Lea>::deoptLeaToAddOrNull(Func)) {

Jim Stichnoth 2016/08/02 03:43:53 this->deoptLeaToAddOrNull(Func) Seriously.

manasijm 2016/08/02 16:08:37 Works! Was 'misguided' by my IDE..

+ Add->emit(Func);

+ return;

+ }

Ostream &Str = Func->getContext()->getStrEmit();

assert(this->getSrcSize() == 1);

assert(this->getDest()->hasReg());