Subzero: Aggressive LEA

src/IceTargetLoweringX86BaseImpl.h

 //===- subzero/src/IceTargetLoweringX86BaseImpl.h - x86 lowering -*- C++ -*-==//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 2165 matching lines @@
       break;
     }
     return;
   }
   Variable *T_edx = nullptr;
   Variable *T = nullptr;
   switch (Instr->getOp()) {
   case InstArithmetic::_num:
     llvm_unreachable("Unknown arithmetic operator");
     break;
-  case InstArithmetic::Add:
-    _mov(T, Src0);
-    _add(T, Src1);
-    _mov(Dest, T);
-    break;
+  case InstArithmetic::Add: {
+    bool ConvertedToLea = false;
+    if (getFlags().getAggressiveLea() &&

[Jim Stichnoth, 2016/07/29 14:27:26]

I wonder if this conditional would be clearer as something like this:

if (auto *Const = llvm::dyn_cast<Constant>(Instr->getSrc(1))) {
  const bool ValidType = (Ty == IceType_i32 ||
                          (Ty == IceType_i64 && Traits::Is64Bit));
  const bool ValidKind = (llvm::isa<ConstantInteger32>(Const) ||
                          llvm::isa<ConstantRelocatable>(Const));
  if (getFlags().getAggressiveLea() && ValidType && ValidKind) {
    ...
    break;
  }
}

[manasijm, 2016/08/01 19:36:21]

Done.

+        (Ty == IceType_i32 || (Ty == IceType_i64 && Traits::Is64Bit))) {
+      Constant *Const = llvm::dyn_cast<Constant>(Instr->getSrc(1));

[Jim Stichnoth, 2016/07/29 14:27:26]

auto *Const

[manasijm, 2016/08/01 19:36:21]

Done.

+      if (Const != nullptr && (llvm::isa<ConstantInteger32>(Const) ||
+                               llvm::isa<ConstantRelocatable>(Const))) {
+        auto *Var = legalizeToReg(Src0);
+        auto *Mem =
+            Traits::X86OperandMem::create(Func, IceType_void, Var, Const);
+        T = makeReg(Ty);
+        _lea(T, _sandbox_mem_reference(Mem));
+        _mov(Dest, T);
+        ConvertedToLea = true;

[Jim Stichnoth, 2016/07/29 14:27:26]

I would just put a "break;" here, and remove ConvertedToLea entirely.

[manasijm, 2016/08/01 19:36:21]

Done.

+      }
+    }
+    if (!ConvertedToLea) {
+      _mov(T, Src0);
+      _add(T, Src1);
+      _mov(Dest, T);
+    }
+  } break;
   case InstArithmetic::And:
     _mov(T, Src0);
     _and(T, Src1);
     _mov(Dest, T);
     break;
   case InstArithmetic::Or:
     _mov(T, Src0);
     _or(T, Src1);
     _mov(Dest, T);
     break;
@@ skipping 5870 matching lines @@
         emitGlobal(*Var, SectionSuffix);
       }
     }
   } break;
   }
 }
 } // end of namespace X86NAMESPACE
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICETARGETLOWERINGX86BASEIMPL_H