Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2135393002: In builder config, change "is_try_bot" -> "is_try_builder". (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In builder config, change "is_try_bot" -> "is_try_builder". In http://crrev.cm/2019463003, I accidentally used is_try_bot in one place and is_try_builder in the rest of the places. This CL makes the usage consistent so that those three builders are actually considered try bots (for the purposes of rebaseline-from-try-bots). Committed: https://crrev.com/2cce834ad526efdca08d32b73eb348187d02bf04 Cr-Commit-Position: refs/heads/master@{#404717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
qyearsley
4 years, 5 months ago (2016-07-11 18:37:41 UTC) #2
wkorman
lgtm
4 years, 5 months ago (2016-07-11 18:39:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135393002/1
4 years, 5 months ago (2016-07-11 18:53:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 20:09:52 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2cce834ad526efdca08d32b73eb348187d02bf04 Cr-Commit-Position: refs/heads/master@{#404717}
4 years, 5 months ago (2016-07-11 20:11:26 UTC) #8
Dirk Pranke
4 years, 4 months ago (2016-08-09 04:00:04 UTC) #9
Message was sent while issue was closed.
lgtm (very belatedly).

Powered by Google App Engine
This is Rietveld 408576698