Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: git_cl.py

Issue 2135313005: Gerrit CQ will not allow customization of CQ label values. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 1a151c7b00352087da54aa61e8d1c4725423c39f..f83e19e8bf95896f8de72413686e6be1eea0c1f4 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2596,8 +2596,6 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
def SetCQState(self, new_state):
"""Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
- # TODO(tandrii): maybe allow configurability in codereview.settings or by
- # self-discovery of label config for this CL using REST API.
vote_map = {
_CQState.NONE: 0,
_CQState.DRY_RUN: 1,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698