Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2135313004: Roll gyp to e7079f0e0e14108ab0dba58728ff219637458563. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll gyp to e7079f0e0e14108ab0dba58728ff219637458563. Picks up: e7079f0 Fix :rfc1034identifier when the value contains underscore. BUG=625875 Committed: https://crrev.com/294a049c6a1c20712a9a813c48e45dc78cfcbfa3 Cr-Commit-Position: refs/heads/master@{#404900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 5 months ago (2016-07-12 16:14:32 UTC) #2
justincohen
lgtm
4 years, 5 months ago (2016-07-12 16:15:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135313004/1
4 years, 5 months ago (2016-07-12 16:16:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242670)
4 years, 5 months ago (2016-07-12 17:39:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135313004/1
4 years, 5 months ago (2016-07-12 17:43:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261173)
4 years, 5 months ago (2016-07-12 19:06:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135313004/1
4 years, 5 months ago (2016-07-12 21:47:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 02:17:58 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 02:18:41 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:19:19 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/294a049c6a1c20712a9a813c48e45dc78cfcbfa3
Cr-Commit-Position: refs/heads/master@{#404900}

Powered by Google App Engine
This is Rietveld 408576698