Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2135313002: [gn] Experiment: Reset -O3 to -O2. (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Experiment: Reset -O3 to -O2. Temporary commit to see performance data. Will be reverted shortly after. BUG=chromium:622332 TBR=vogelheim, jochen NOTRY=true Committed: https://crrev.com/bbb61d8aea732457e1d5a0c9abdd79eacf1622ae Cr-Commit-Position: refs/heads/master@{#37667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gni/v8.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Achenbach
PTAL. Will revert after alerts are created. I also ran perf trybots but results are ...
4 years, 5 months ago (2016-07-11 18:35:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135313002/1
4 years, 5 months ago (2016-07-12 08:34:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 08:36:19 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 08:36:20 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bbb61d8aea732457e1d5a0c9abdd79eacf1622ae Cr-Commit-Position: refs/heads/master@{#37667}
4 years, 5 months ago (2016-07-12 08:37:40 UTC) #12
Michael Achenbach
4 years, 5 months ago (2016-07-12 18:18:31 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2141113002/ by machenbach@chromium.org.

The reason for reverting is: Data collected
.

Powered by Google App Engine
This is Rietveld 408576698