Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 21353002: Reimplement TypedArray.set in Javascript. (Closed)

Created:
7 years, 4 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reimplement TypedArray.set in Javascript. Implement all cases for TypedArray.set in Javascript, except the case where memmove is used. This makes it many times faster. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -95 lines) Patch
M src/runtime.cc View 4 chunks +27 lines, -76 lines 0 comments Download
M src/typedarray.js View 1 chunk +92 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
7 years, 4 months ago (2013-07-31 11:45:03 UTC) #1
Benedikt Meurer
lgtm
7 years, 4 months ago (2013-07-31 12:03:19 UTC) #2
Dmitry Lomov (no reviews)
7 years, 4 months ago (2013-07-31 12:11:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698