test/cctest/compiler/value-helper.h - Issue 2135243004: [test] Change or replace unrepresentable number in the lists of float test values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/value-helper.h

Issue 2135243004: [test] Change or replace unrepresentable number in the lists of float test values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/compiler/value-helper.h

diff --git a/test/cctest/compiler/value-helper.h b/test/cctest/compiler/value-helper.h

index 22982b8ac64d283edf9b3fc9c6426f4b6a330b18..6b8c645e487565d3463c75fd5e481574350bb31e 100644

--- a/test/cctest/compiler/value-helper.h

+++ b/test/cctest/compiler/value-helper.h

@@ -82,7 +82,6 @@ class ValueHelper {

-4.66622e+11f,

-2.22581e+11f,

-1.45381e+10f,

- -2147483649.0f, // INT32_MIN - 1

titzer 2016/07/12 09:08:12 Can you add a number which is one fup less than IN

ahaas 2016/07/12 09:35:28 Done.

-2147483648.0f, // INT32_MIN

-1.3956e+09f,

-1.32951e+09f,

@@ -158,8 +157,8 @@ class ValueHelper {

1.51116e+11f,

4.18193e+13f,

3.59167e+16f,

- 9223372036854775807.0f, // INT64_MAX

- 18446744073709551615.0f, // UINT64_MAX

+ 9223372036854775808.0f, // INT64_MAX + 1

+ 18446744073709551616.0f, // UINT64_MAX + 1

3.38211e+19f,

2.67488e+20f,

1.78831e+21f,

@@ -224,9 +223,9 @@ class ValueHelper {

2147483648.0,

2147483648.25,

2147483649.25,

- 9223372036854775807.0, // INT64_MAX

+ 9223372036854775808.0, // INT64_MAX + 1

9223373136366403584.0,

- 18446744073709551615.0, // UINT64_MAX

+ 18446744073709551616.0, // UINT64_MAX + 1

2e66,

V8_INFINITY,

-V8_INFINITY,

« no previous file with comments | « no previous file | no next file » | no next file with comments »