Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2135243004: [test] Change or replace unrepresentable number in the lists of float test values. (Closed)

Created:
4 years, 5 months ago by ahaas
Modified:
4 years, 5 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Change or replace unrepresentable number in the lists of float test values. I removed or replaced some values in the list of float and double values in value-helper.h which cannot be represented precisely as floats or doubles, respectively. R=titzer@chromium.org Committed: https://crrev.com/b571026f26e595be6d01c6e68829d7e1574c8320 Cr-Commit-Position: refs/heads/master@{#37671}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add first float after and last float before INT32_MIN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M test/cctest/compiler/value-helper.h View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ahaas
4 years, 5 months ago (2016-07-12 08:45:12 UTC) #1
titzer
https://codereview.chromium.org/2135243004/diff/1/test/cctest/compiler/value-helper.h File test/cctest/compiler/value-helper.h (left): https://codereview.chromium.org/2135243004/diff/1/test/cctest/compiler/value-helper.h#oldcode85 test/cctest/compiler/value-helper.h:85: -2147483649.0f, // INT32_MIN - 1 Can you add a ...
4 years, 5 months ago (2016-07-12 09:08:12 UTC) #2
ahaas
https://codereview.chromium.org/2135243004/diff/1/test/cctest/compiler/value-helper.h File test/cctest/compiler/value-helper.h (left): https://codereview.chromium.org/2135243004/diff/1/test/cctest/compiler/value-helper.h#oldcode85 test/cctest/compiler/value-helper.h:85: -2147483649.0f, // INT32_MIN - 1 On 2016/07/12 at 09:08:12, ...
4 years, 5 months ago (2016-07-12 09:35:28 UTC) #3
titzer
lgtm
4 years, 5 months ago (2016-07-12 09:43:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135243004/20001
4 years, 5 months ago (2016-07-12 09:45:23 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 10:07:45 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 10:07:47 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 10:09:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b571026f26e595be6d01c6e68829d7e1574c8320
Cr-Commit-Position: refs/heads/master@{#37671}

Powered by Google App Engine
This is Rietveld 408576698