Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2135243002: Changed 'heartbeat' in policy json file to 'monitoring network packets' and tweaked descriptions. (Closed)

Created:
4 years, 5 months ago by ljusten (tachyonic)
Modified:
4 years, 5 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, tnagel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed 'heartbeat' in policy json file to 'monitoring network packets' and tweaked descriptions. BUG=541553 Committed: https://crrev.com/c5e16abb6114b031190192fb4f1e18bc9743bae2 Cr-Commit-Position: refs/heads/master@{#405449}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed 'heartbeat' in policy json file to 'monitoring network packets' and tweaked descriptions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/policy/resources/policy_templates.json View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
ljusten (tachyonic)
Hey Thiemo, please review my string change. There was a problem with the try build, ...
4 years, 5 months ago (2016-07-11 12:52:45 UTC) #2
Thiemo Nagel
> There was a problem with the try build, see > What does that mean? ...
4 years, 5 months ago (2016-07-11 14:33:21 UTC) #3
ljusten (tachyonic)
Took .gitignore out and removed the "then"
4 years, 5 months ago (2016-07-12 10:51:48 UTC) #4
Thiemo Nagel
lgtm
4 years, 5 months ago (2016-07-12 10:58:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135243002/20001
4 years, 5 months ago (2016-07-12 11:07:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191198)
4 years, 5 months ago (2016-07-12 13:09:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135243002/20001
4 years, 5 months ago (2016-07-14 07:28:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 08:07:43 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 08:07:46 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 08:09:21 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5e16abb6114b031190192fb4f1e18bc9743bae2
Cr-Commit-Position: refs/heads/master@{#405449}

Powered by Google App Engine
This is Rietveld 408576698