Use spin runloop instead of WaitForIncomingMethodCall() for test codes.

Use spin runloop instead of WaitForIncomingMethodCall() for test codes.

This CL replaces usage of Binding::WaitForIncomingMethodCall() with
a spin runloop waiting for incoming call or a connection error.
Affected test codes are within:
  components/arc/
  services/shell/

BUG=622438
Committed: https://crrev.com/6d3b0b6a6d105068e79dd14e2d37dea2de2a7500
Cr-Commit-Position: refs/heads/master@{#407029}

[leonhsl(Using Gerrit), 2016-07-11 10:44:22]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 10:44:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 11:01:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 11:01:27]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[leonhsl(Using Gerrit), 2016-07-11 11:26:59]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 11:27:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 11:57:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 11:57:20]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2016-07-11 13:07:02]

leon.han@intel.com changed reviewers:
+ lhchavez@chromium.org, rockot@chromium.org, yzshen@chromium.org

[leonhsl(Using Gerrit), 2016-07-11 13:07:03]

This CL changes all the test codes calling WaitForIncomingMethodCall, would you
PTAL? Thanks.

lhchavez@ : For OWNER review of components/arc/.
Ken : For OWNER review of services/shell/ and overall review.
Yuzhu : For overall review.

As for production code using WaitForIncomingMethodCall, I think maybe we need to
change some logic of those mojo interfaces according different situations, so
I'd like to dip down and handle them with follow-up CL.

[Luis Héctor Chávez, 2016-07-11 14:48:03]

On 2016/07/11 13:07:03, leonhsl wrote:
> This CL changes all the test codes calling WaitForIncomingMethodCall, would
you
> PTAL? Thanks.
> 
> lhchavez@ : For OWNER review of components/arc/.
> Ken : For OWNER review of services/shell/ and overall review.
> Yuzhu : For overall review.
> 
> As for production code using WaitForIncomingMethodCall, I think maybe we need
to
> change some logic of those mojo interfaces according different situations, so
> I'd like to dip down and handle them with follow-up CL.

Oh I was just about to totally remove the WaitForIncomingMethodCall requirement
in tests with https://codereview.chromium.org/2138513002/

Is it possible that you wait until that change lands? It'll make things easier
for everybody.

[leonhsl(Using Gerrit), 2016-07-12 01:23:50]

On 2016/07/11 14:48:03, Luis Héctor Chávez wrote:
> On 2016/07/11 13:07:03, leonhsl wrote:
> > This CL changes all the test codes calling WaitForIncomingMethodCall, would
> you
> > PTAL? Thanks.
> > 
> > lhchavez@ : For OWNER review of components/arc/.
> > Ken : For OWNER review of services/shell/ and overall review.
> > Yuzhu : For overall review.
> > 
> > As for production code using WaitForIncomingMethodCall, I think maybe we
need
> to
> > change some logic of those mojo interfaces according different situations,
so
> > I'd like to dip down and handle them with follow-up CL.
> 
> Oh I was just about to totally remove the WaitForIncomingMethodCall
requirement
> in tests with https://codereview.chromium.org/2138513002/
> 
> Is it possible that you wait until that change lands? It'll make things easier
> for everybody.

OK, got it, Thanks for sharing the information. I'll revisit later.

[Luis Héctor Chávez, 2016-07-13 15:19:10]

On 2016/07/12 01:23:50, leonhsl wrote:
> On 2016/07/11 14:48:03, Luis Héctor Chávez wrote:
> > On 2016/07/11 13:07:03, leonhsl wrote:
> > > This CL changes all the test codes calling WaitForIncomingMethodCall,
would
> > you
> > > PTAL? Thanks.
> > > 
> > > lhchavez@ : For OWNER review of components/arc/.
> > > Ken : For OWNER review of services/shell/ and overall review.
> > > Yuzhu : For overall review.
> > > 
> > > As for production code using WaitForIncomingMethodCall, I think maybe we
> need
> > to
> > > change some logic of those mojo interfaces according different situations,
> so
> > > I'd like to dip down and handle them with follow-up CL.
> > 
> > Oh I was just about to totally remove the WaitForIncomingMethodCall
> requirement
> > in tests with https://codereview.chromium.org/2138513002/
> > 
> > Is it possible that you wait until that change lands? It'll make things
easier
> > for everybody.
> 
> OK, got it, Thanks for sharing the information. I'll revisit later.

that other change has just landed.

[leonhsl(Using Gerrit), 2016-07-18 07:24:53]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 07:25:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 08:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 08:07:22]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2016-07-18 09:44:28]

Uploaded ps#3 to rebase, PTAnL, Thanks.

[yzshen1, 2016-07-18 15:40:03]

LGTM

[Luis Héctor Chávez, 2016-07-18 15:41:00]

components/arc LGTM

thanks for waiting!

[leonhsl(Using Gerrit), 2016-07-20 02:13:45]

Hi, Ken, would you PTAL for OWNER review of services/shell/ ? Thanks~

[Ken Rockot(use gerrit already), 2016-07-21 22:26:49]

lgtm

[leonhsl(Using Gerrit), 2016-07-22 02:01:07]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2016-07-22 02:02:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:34:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 03:36:02]

Description was changed from

==========
Use spin runloop instead of WaitForIncomingMethodCall() for test codes.

This CL replaces usage of Binding::WaitForIncomingMethodCall() with
a spin runloop waiting for incoming call or a connection error.
Affected test codes are within:
  components/arc/
  services/shell/

BUG=622438
==========

to

==========
Use spin runloop instead of WaitForIncomingMethodCall() for test codes.

This CL replaces usage of Binding::WaitForIncomingMethodCall() with
a spin runloop waiting for incoming call or a connection error.
Affected test codes are within:
  components/arc/
  services/shell/

BUG=622438

Committed: https://crrev.com/6d3b0b6a6d105068e79dd14e2d37dea2de2a7500
Cr-Commit-Position: refs/heads/master@{#407029}
==========

[commit-bot: I haz the power, 2016-07-22 03:36:03]

Patchset 3 (id:??) landed as
https://crrev.com/6d3b0b6a6d105068e79dd14e2d37dea2de2a7500
Cr-Commit-Position: refs/heads/master@{#407029}