Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 2135203002: A frameset tag inside template should be simply ignored. (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A frameset tag inside template should be simply ignored. As stated in the spec, <template> tag start token should set frameset-ok flag to false when in in-body/in-head insertion mode. https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody BUG=475002 Committed: https://crrev.com/93198017327e240584facc073ae5853a1cc78a6c Cr-Commit-Position: refs/heads/master@{#404632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/parser/disable-frameset-ok-flag-inside-template.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/parser/resources/frameset-inside-template.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kouhei (in TOK)
4 years, 5 months ago (2016-07-11 10:20:46 UTC) #2
hayato
lgtm
4 years, 5 months ago (2016-07-11 10:25:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135203002/1
4 years, 5 months ago (2016-07-11 10:27:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 11:29:54 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 11:29:56 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 11:31:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93198017327e240584facc073ae5853a1cc78a6c
Cr-Commit-Position: refs/heads/master@{#404632}

Powered by Google App Engine
This is Rietveld 408576698