Issue 21352003: Remove a stray double assign that g++ 4.8 thinks has ill-defined sequencing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21352003: Remove a stray double assign that g++ 4.8 thinks has ill-defined sequencing. (Closed)

Created:
7 years, 4 months ago by mtklein

Modified:
7 years, 4 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Remove a stray double assign that g++ 4.8 thinks has ill-defined sequencing. BUG= R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=10462

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/core/SkTemplates.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

bungeman-skia

Assign to the same variable twice in the same expression? That's a paddlin'! lgtm

7 years, 4 months ago (2013-07-31 14:43:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/21352003/1

7 years, 4 months ago (2013-07-31 14:44:16 UTC) #3

mtklein

7 years, 4 months ago (2013-07-31 16:01:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r10462 (presubmit successful).