Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2135193002: Revert of Re-enable DataReductionPromoInfoBar tests and fix flakiness (Closed)

Created:
4 years, 5 months ago by picksi1
Modified:
4 years, 5 months ago
Reviewers:
gone, rmcilroy, megjablon
CC:
chromium-reviews, Peter Wen
Base URL:
https://chromium.googlesource.com/chromium/src.git@settingsPage
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable DataReductionPromoInfoBar tests and fix flakiness (patchset #3 id:60001 of https://codereview.chromium.org/2130083002/ ) Reason for revert: A number of related tests have started failing (see https://bugs.chromium.org/p/chromium/issues/detail?id=627038) Original issue's description: > Re-enable DataReductionPromoInfoBar tests and fix flakiness > > StrictMode violation was from Calendar.getInstance() reading > the /etc/timezone file. Whitelist the StrictMode violation > to be fixed. > > Tests were flaky because the UI thread would not always launch > the InfoBar before calling addInfoBarAnimationFinished(). Run > the UI thread blocking so that the InfoBar has always been > launched. > > BUG=625038, 577185 > > Committed: https://crrev.com/8fcd3f03a3a531f12bb291dc8665834d85511c23 > Cr-Commit-Position: refs/heads/master@{#404506} TBR=dfalcantara@chromium.org,megjablon@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625038, 577185 Committed: https://crrev.com/497683de6aa37f9a912b5b62808c84d82f987b67 Cr-Commit-Position: refs/heads/master@{#404629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionPromoInfoBar.java View 3 chunks +1 line, -12 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 11 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
picksi1
Created Revert of Re-enable DataReductionPromoInfoBar tests and fix flakiness
4 years, 5 months ago (2016-07-11 10:16:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135193002/1
4 years, 5 months ago (2016-07-11 10:17:06 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-11 10:17:08 UTC) #5
rmcilroy
lgtm
4 years, 5 months ago (2016-07-11 10:19:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135193002/1
4 years, 5 months ago (2016-07-11 10:19:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 10:48:28 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 10:48:29 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 10:49:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/497683de6aa37f9a912b5b62808c84d82f987b67
Cr-Commit-Position: refs/heads/master@{#404629}

Powered by Google App Engine
This is Rietveld 408576698