Scroll the attached view when wheel spinned on top of a scroll button.

Scroll the attached view when wheel spinned on top of a scroll button.

BUG=600697
TEST=manually

Committed: https://crrev.com/c4b85f71622b4e65bde77a4045402ba65472ed57
Cr-Commit-Position: refs/heads/master@{#404631}

[yamaguchi, 2016-07-11 09:54:11]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org, oka@chromium.org

[yamaguchi, 2016-07-11 09:54:11]

PTAL

[fukino, 2016-07-11 10:09:52]

Thank you!

https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/scrollbar.js (right):

https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/scrollbar.js:54:
this.button_.addEventListener('mousewheel', this.onWheel_.bind(this));
mousewheel event is deprecated, so please use the standard wheel event.

https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/scrollbar.js:101: 
Please add a comment about the difference between native scroll and this manual
scroll.

[yamaguchi, 2016-07-11 10:15:29]

On 2016/07/11 10:09:52, fukino wrote:
> Thank you!
> 
>
https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
> File ui/file_manager/file_manager/foreground/js/ui/scrollbar.js (right):
> 
>
https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/js/ui/scrollbar.js:54:
> this.button_.addEventListener('mousewheel', this.onWheel_.bind(this));
> mousewheel event is deprecated, so please use the standard wheel event.
> 
>
https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/js/ui/scrollbar.js:101: 
> Please add a comment about the difference between native scroll and this
manual
> scroll.

Done.

[yamaguchi, 2016-07-11 10:17:20]

https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/scrollbar.js (right):

https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/scrollbar.js:54:
this.button_.addEventListener('mousewheel', this.onWheel_.bind(this));
On 2016/07/11 10:09:52, fukino wrote:
> mousewheel event is deprecated, so please use the standard wheel event.

Done.

https://codereview.chromium.org/2135163002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/scrollbar.js:101: 
On 2016/07/11 10:09:52, fukino wrote:
> Please add a comment about the difference between native scroll and this
manual
> scroll.

Done.

[fukino, 2016-07-11 10:19:12]

https://codereview.chromium.org/2135163002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/scrollbar.js (right):

https://codereview.chromium.org/2135163002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/scrollbar.js:103: //     This
implementation will bypass the smooth scroll animation seen with
nit: You don't need to indent here.

[yamaguchi, 2016-07-11 10:23:07]

https://codereview.chromium.org/2135163002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/scrollbar.js (right):

https://codereview.chromium.org/2135163002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/scrollbar.js:103: //     This
implementation will bypass the smooth scroll animation seen with
On 2016/07/11 10:19:12, fukino wrote:
> nit: You don't need to indent here.

Done.

[fukino, 2016-07-11 10:23:47]

LGTM!

[yamaguchi, 2016-07-11 10:24:24]

The CQ bit was checked by yamaguchi@chromium.org

[commit-bot: I haz the power, 2016-07-11 10:24:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 11:06:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-11 11:06:20]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 11:07:37]

Description was changed from

==========
Scroll the attached view when wheel spinned on top of a scroll button.

BUG=600697
TEST=manually
==========

to

==========
Scroll the attached view when wheel spinned on top of a scroll button.

BUG=600697
TEST=manually

Committed: https://crrev.com/c4b85f71622b4e65bde77a4045402ba65472ed57
Cr-Commit-Position: refs/heads/master@{#404631}
==========

[commit-bot: I haz the power, 2016-07-11 11:07:38]

Patchset 4 (id:??) landed as
https://crrev.com/c4b85f71622b4e65bde77a4045402ba65472ed57
Cr-Commit-Position: refs/heads/master@{#404631}