Implement SignedCertificateTimestamp::isolatedCopy

Implement SignedCertificateTimestamp::isolatedCopy

As ResourceResponse::SignedCertificateTimestamp contains String members, it
should have isolatedCopy function and that function should be called in
ResourceResponse::copyData.

BUG=626809
Committed: https://crrev.com/6aa36b6c741ab188448a6673c393af135ee6572e
Cr-Commit-Position: refs/heads/master@{#404962}

[yhirano, 2016-07-11 09:30:49]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org

[hiroshige, 2016-07-11 10:09:45]

lgtm with a comment.

Adding tests are preferable (ResourceResponse lacks tests from before though).

https://codereview.chromium.org/2135143002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ResourceResponse.cpp (right):

https://codereview.chromium.org/2135143002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ResourceResponse.cpp:170:
m_securityDetails.sctList = isolatedCopy(data->m_securityDetails.sctList);
This isolatedCopy() is not necessary because this is called after crossing the
thread boundary and we can use |*this| and |*data| freely on the target thread.

[yhirano, 2016-07-12 05:14:42]

Added a small test.

https://codereview.chromium.org/2135143002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ResourceResponse.cpp (right):

https://codereview.chromium.org/2135143002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ResourceResponse.cpp:170:
m_securityDetails.sctList = isolatedCopy(data->m_securityDetails.sctList);
On 2016/07/11 10:09:45, hiroshige wrote:
> This isolatedCopy() is not necessary because this is called after crossing the
> thread boundary and we can use |*this| and |*data| freely on the target
thread.

Thanks, done.

[yhirano, 2016-07-12 05:15:11]

yhirano@chromium.org changed reviewers:
+ mkwst@chromium.org

[yhirano, 2016-07-12 05:15:11]

+mkwst

[hiroshige, 2016-07-12 05:45:27]

lgtm again.

[Mike West, 2016-07-12 09:34:44]

LGTM.

[yhirano, 2016-07-12 09:55:10]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-07-12 09:55:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 10:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 10:54:58]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[yhirano, 2016-07-12 11:01:38]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-07-12 11:01:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2135143002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-07-12 11:02:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 15:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:03:51]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-07-12 16:07:40]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-07-12 16:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 20:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:20:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2016-07-13 01:42:23]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-07-13 01:44:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 03:29:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-13 03:29:42]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 03:32:36]

Description was changed from

==========
Implement SignedCertificateTimestamp::isolatedCopy

As ResourceResponse::SignedCertificateTimestamp contains String members, it
should have isolatedCopy function and that function should be called in
ResourceResponse::copyData.

BUG=626809
==========

to

==========
Implement SignedCertificateTimestamp::isolatedCopy

As ResourceResponse::SignedCertificateTimestamp contains String members, it
should have isolatedCopy function and that function should be called in
ResourceResponse::copyData.

BUG=626809

Committed: https://crrev.com/6aa36b6c741ab188448a6673c393af135ee6572e
Cr-Commit-Position: refs/heads/master@{#404962}
==========

[commit-bot: I haz the power, 2016-07-13 03:32:38]

Patchset 3 (id:??) landed as
https://crrev.com/6aa36b6c741ab188448a6673c393af135ee6572e
Cr-Commit-Position: refs/heads/master@{#404962}