Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: content/browser/loader/async_resource_handler.cc

Issue 2135133002: Remove untaken branches from AsyncResourceHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/async_resource_handler.cc
diff --git a/content/browser/loader/async_resource_handler.cc b/content/browser/loader/async_resource_handler.cc
index a735d594a06135b0c71642e862e6f657cfcebede..d038898a2c574133f36a3c314a1018056f987a9a 100644
--- a/content/browser/loader/async_resource_handler.cc
+++ b/content/browser/loader/async_resource_handler.cc
@@ -513,16 +513,6 @@ void AsyncResourceHandler::OnResponseCompleted(
// the ERR_ABORTED error code).
DCHECK(!was_ignored_by_handler || error_code == net::ERR_ABORTED);
- // TODO(mkosiba): Fix up cases where we create a URLRequestStatus
- // with a status() != SUCCESS and an error_code() == net::OK.
- if (status.status() == net::URLRequestStatus::CANCELED &&
- error_code == net::OK) {
- error_code = net::ERR_ABORTED;
- } else if (status.status() == net::URLRequestStatus::FAILED &&
- error_code == net::OK) {
- error_code = net::ERR_FAILED;
- }
-
ResourceRequestCompletionStatus request_complete_data;
request_complete_data.error_code = error_code;
request_complete_data.was_ignored_by_handler = was_ignored_by_handler;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698