Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issue 2135133002: Remove untaken branches from AsyncResourceHandler (Closed)

Created:
4 years, 5 months ago by yhirano
Modified:
4 years, 5 months ago
Reviewers:
mmenke
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove untaken branches from AsyncResourceHandler As it's not possible to create a URLRequestStatus whose status is CANCELLED or FAILED and whose error code is OK, the branch in AsyncResourceHandler to sanitize such status is no longer needed. BUG=None Committed: https://crrev.com/f79dd600197ff8025c76aa9cf31e163832c37096 Cr-Commit-Position: refs/heads/master@{#404647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yhirano
FYI: https://codereview.chromium.org/1239993004
4 years, 5 months ago (2016-07-11 10:22:55 UTC) #2
mmenke
On 2016/07/11 10:22:55, yhirano wrote: > FYI: https://codereview.chromium.org/1239993004 LGTM, thanks for the cleanup!
4 years, 5 months ago (2016-07-11 12:18:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135133002/1
4 years, 5 months ago (2016-07-11 12:41:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 13:21:00 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 13:21:02 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 13:22:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f79dd600197ff8025c76aa9cf31e163832c37096
Cr-Commit-Position: refs/heads/master@{#404647}

Powered by Google App Engine
This is Rietveld 408576698