Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2135083003: Initialize gFunctionMap from CoreInitializer (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
Reviewers:
Yoav Weiss
CC:
chromium-reviews, kenneth.christiansen, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize gFunctionMap from CoreInitializer Before this CL, gFunctionMap init was racy, as it could be initialized from both BackgroundParserThread/CrRendererMain. This CL ties the init to blink::initialize() to avoid the issue. BUG=626493 Committed: https://crrev.com/ce6b9dfd435e967107e9677a902371864ef1bc59 Cr-Commit-Position: refs/heads/master@{#404738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/CoreInitializer.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kouhei (in TOK)
4 years, 5 months ago (2016-07-11 14:23:45 UTC) #2
Yoav Weiss
On 2016/07/11 14:23:45, kouhei wrote: LGTM
4 years, 5 months ago (2016-07-11 14:33:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135083003/1
4 years, 5 months ago (2016-07-11 21:38:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 21:44:02 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 21:44:04 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 21:45:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce6b9dfd435e967107e9677a902371864ef1bc59
Cr-Commit-Position: refs/heads/master@{#404738}

Powered by Google App Engine
This is Rietveld 408576698