DescriptionRevert of Simplify ppapi Graphics3D size propagation a bit (patchset #5 id:80001 of https://codereview.chromium.org/2136743002/ )
Reason for revert:
Build breakage on Win8 GYP.
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/507
FAILED: nacl64.exe nacl64.exe.pdb
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True nacl64.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:nacl64.exe @nacl64.exe.rsp" 1 mt.exe rc.exe "obj\chrome\chrome_nacl_win64.nacl64.exe.intermediate.manifest" obj\chrome\chrome_nacl_win64.nacl64.exe.generated.manifest ..\..\build\win\compatibility.manifest
ppapi_ipc_win64.lib(ppapi_ipc_win64.ppapi_messages.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl gfx::Size::Size(void)" (__imp_??0Size@gfx@@QEAA@XZ) referenced in function "public: __cdecl std::_Tuple_val<class gfx::Size>::_Tuple_val<class gfx::Size>(void)" (??0?$_Tuple_val@VSize@gfx@@@std@@QEAA@XZ)
nacl64.exe : fatal error LNK1120: 1 unresolved externals
Original issue's description:
> Simplify ppapi Graphics3D size propagation a bit
>
> - after https://codereview.chromium.org/2104403003/ we parse the attributes from
> the plugin side, so we know the correct size from the start, and we don't need
> to track the original size.
> - we can also pass gfx::Size through IPC with some extra validation (negative
> coordinates) in common code.
> - overall net fewer lines
>
> BUG=None
>
> Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381
> Cr-Commit-Position: refs/heads/master@{#404580}
TBR=erikchen@chromium.org,bbudge@chromium.org,dcheng@chromium.org,danakj@chromium.org,piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Committed: https://crrev.com/6b6d7dfd6a8de29daea667fb7dfc2ff1ca64cb10
Cr-Commit-Position: refs/heads/master@{#404582}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|