Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2135063002: Revert of Simplify ppapi Graphics3D size propagation a bit (Closed)

Created:
4 years, 5 months ago by Yuki
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_attr_parse_to_pepper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify ppapi Graphics3D size propagation a bit (patchset #5 id:80001 of https://codereview.chromium.org/2136743002/ ) Reason for revert: Build breakage on Win8 GYP. https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/507 FAILED: nacl64.exe nacl64.exe.pdb E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True nacl64.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:nacl64.exe @nacl64.exe.rsp" 1 mt.exe rc.exe "obj\chrome\chrome_nacl_win64.nacl64.exe.intermediate.manifest" obj\chrome\chrome_nacl_win64.nacl64.exe.generated.manifest ..\..\build\win\compatibility.manifest ppapi_ipc_win64.lib(ppapi_ipc_win64.ppapi_messages.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl gfx::Size::Size(void)" (__imp_??0Size@gfx@@QEAA@XZ) referenced in function "public: __cdecl std::_Tuple_val<class gfx::Size>::_Tuple_val<class gfx::Size>(void)" (??0?$_Tuple_val@VSize@gfx@@@std@@QEAA@XZ) nacl64.exe : fatal error LNK1120: 1 unresolved externals Original issue's description: > Simplify ppapi Graphics3D size propagation a bit > > - after https://codereview.chromium.org/2104403003/ we parse the attributes from > the plugin side, so we know the correct size from the start, and we don't need > to track the original size. > - we can also pass gfx::Size through IPC with some extra validation (negative > coordinates) in common code. > - overall net fewer lines > > BUG=None > > Committed: https://crrev.com/1135d428cd8f5b19d458c5e67ba90776c4e09381 > Cr-Commit-Position: refs/heads/master@{#404580} TBR=erikchen@chromium.org,bbudge@chromium.org,dcheng@chromium.org,danakj@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/6b6d7dfd6a8de29daea667fb7dfc2ff1ca64cb10 Cr-Commit-Position: refs/heads/master@{#404582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -48 lines) Patch
M content/renderer/pepper/ppb_graphics_3d_impl.h View 2 chunks +8 lines, -1 line 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M ppapi/ppapi_internal.gyp View 5 chunks +0 lines, -5 lines 0 comments Download
M ppapi/ppapi_proxy_nacl.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_shared_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 3 chunks +5 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M ppapi/proxy/video_decoder_resource_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.h View 4 chunks +8 lines, -8 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yuki
Created Revert of Simplify ppapi Graphics3D size propagation a bit
4 years, 5 months ago (2016-07-11 00:36:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135063002/1
4 years, 5 months ago (2016-07-11 00:36:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 00:38:41 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 00:41:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b6d7dfd6a8de29daea667fb7dfc2ff1ca64cb10
Cr-Commit-Position: refs/heads/master@{#404582}

Powered by Google App Engine
This is Rietveld 408576698