Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2135053002: Simplify MSAA path renderer (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
ethannicholas
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify MSAA path renderer This simplification is based on the observations that: there were never more than 2 passes the only time passes[] was null was the single-pass, !stencilOnly case only kBoth_DrawFace was was ever used BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135053002 Committed: https://skia.googlesource.com/skia/+/8e375309caf1628aff28c58d3e87156f3f67c16c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M src/gpu/batches/GrMSAAPathRenderer.cpp View 7 chunks +11 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
robertphillips
4 years, 5 months ago (2016-07-10 19:20:20 UTC) #4
robertphillips
ping
4 years, 5 months ago (2016-07-11 15:11:21 UTC) #9
ethannicholas
lgtm
4 years, 5 months ago (2016-07-11 16:31:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135053002/1
4 years, 5 months ago (2016-07-11 17:43:02 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 17:44:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8e375309caf1628aff28c58d3e87156f3f67c16c

Powered by Google App Engine
This is Rietveld 408576698