Issue 2135033002: Restore writing ObjectPool immediates as intptr_t.

Issue 2135033002: Restore writing ObjectPool immediates as intptr_t. (Closed)

Created:
4 years, 5 months ago by rmacnak

Modified:
4 years, 5 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Restore writing ObjectPool immediates as intptr_t. Fixes 64-bit AOT and caching-JIT snapshots. Corrects over-zealous conversion of snapshot intptr_t fields to int32_t. Any snapshot containing an ObjectPool is already architecture-specific and so word-size specific. TBR=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/ab14b12962262bbfb8c5e28ce1ceb0a879e6492c

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/clustered_snapshot.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (3 generated)

rmacnak

4 years, 5 months ago (2016-07-10 01:23:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ab14b12962262bbfb8c5e28ce1ceb0a879e6492c (presubmit successful).