Issue 2134943002: Make the ChromeOS overview window clear its mask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2134943002: Make the ChromeOS overview window clear its mask (Closed)

Created:
4 years, 5 months ago by enne (OOO)

Modified:
4 years, 5 months ago

Reviewers:
varkha

CC:
chromium-reviews, kalyank, sadrul, tdanderson

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make the ChromeOS overview window clear its mask Its paint routine does not completely fill the bounds and so it is not opaque. Marking it as such forces cc to clear before rastering. R=varkha@chromium.org BUG=626080

Patch Set 1 #

Total comments: 1

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ash/common/wm/overview/scoped_transform_overview_window.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

varkha

https://codereview.chromium.org/2134943002/diff/1/ash/common/wm/overview/scoped_transform_overview_window.cc File ash/common/wm/overview/scoped_transform_overview_window.cc (right): https://codereview.chromium.org/2134943002/diff/1/ash/common/wm/overview/scoped_transform_overview_window.cc#newcode403 ash/common/wm/overview/scoped_transform_overview_window.cc:403: mask_->layer()->SetFillsBoundsOpaquely(false); Brilliant, thanks for a quick tip! The code ...

4 years, 5 months ago (2016-07-09 11:26:13 UTC) #1

varkha

4 years, 5 months ago (2016-07-09 22:08:09 UTC) #2

Thanks again. I have integrated this fix into
https://codereview.chromium.org/2129213003/ and will close this CL.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages