Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2134933002: Suggest `gn help` for internally set arguments. (Closed)

Created:
4 years, 5 months ago by sandersd (OOO until July 31)
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suggest `gn help` for internally set arguments. Hopefully this will help point new users to the existing documentation. Committed: https://crrev.com/45a841b0259335a05874d2ab3acabcc4e3edfe73 Cr-Commit-Position: refs/heads/master@{#404714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn/command_args.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sandersd (OOO until July 31)
A teammate wasn't sure how to toggle is_chromeos, I'm hoping that this would have helped. ...
4 years, 5 months ago (2016-07-08 22:10:21 UTC) #2
brettw
LGTM but this will not affect is_chromeos which is neither internally set nor a build ...
4 years, 5 months ago (2016-07-10 17:36:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134933002/1
4 years, 5 months ago (2016-07-11 19:25:57 UTC) #5
sandersd (OOO until July 31)
On 2016/07/10 17:36:36, brettw (ping after 24h) wrote: > LGTM but this will not affect ...
4 years, 5 months ago (2016-07-11 19:26:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 20:05:08 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 20:06:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45a841b0259335a05874d2ab3acabcc4e3edfe73
Cr-Commit-Position: refs/heads/master@{#404714}

Powered by Google App Engine
This is Rietveld 408576698