Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2134883002: Enable function level linking in product mode for windows so that dead code is eliminated and there… (Closed)

Created:
4 years, 5 months ago by siva
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable function level linking in product mode for windows so that dead code is eliminated and there are no references to code which is not in product mode. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/2ababdc976a40e1213f94e709a012da53b2cf0f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gyp/configurations_msvs.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 5 months ago (2016-07-08 21:25:19 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-07-08 21:28:54 UTC) #3
siva
4 years, 5 months ago (2016-07-08 21:32:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ababdc976a40e1213f94e709a012da53b2cf0f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698