Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2134853002: Fixes ClipboardRecentContentIOSTest on iOS 10. (Closed)

Created:
4 years, 5 months ago by rohitrao (ping after 24h)
Modified:
4 years, 5 months ago
Reviewers:
jif, justincohen
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes ClipboardRecentContentIOSTest on iOS 10. AddingNonStringRemovesCachedString was failing because it is now an error to copy an empty UIImage to the pasteboard. BUG=626686 Committed: https://crrev.com/850dda6b73575be3e6e34ed9da82263f6cc1d5f2 Cr-Commit-Position: refs/heads/master@{#404586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm View 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
rohitrao (ping after 24h)
4 years, 5 months ago (2016-07-08 20:35:23 UTC) #2
jif
lgtm
4 years, 5 months ago (2016-07-10 09:00:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134853002/1
4 years, 5 months ago (2016-07-10 09:00:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 01:14:11 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 01:14:12 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 01:16:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/850dda6b73575be3e6e34ed9da82263f6cc1d5f2
Cr-Commit-Position: refs/heads/master@{#404586}

Powered by Google App Engine
This is Rietveld 408576698