Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Issue 2134833002: ash: Move VirtualKeyboardStateObserver functionality to ShellObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/login_display_host_impl.cc
diff --git a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
index 6245d6f4f5dd7e465b13c1782a2607937d0cf034..28312bf48ec46c8f5fcd10bf6d774fefa8ee9e01 100644
--- a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
+++ b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
@@ -301,7 +301,7 @@ LoginDisplayHostImpl::LoginDisplayHostImpl(const gfx::Rect& background_bounds)
}
if (!chrome::IsRunningInMash())
- ash::WmShell::Get()->delegate()->AddVirtualKeyboardStateObserver(this);
+ ash::WmShell::Get()->AddShellObserver(this);
else
NOTIMPLEMENTED();
display::Screen::GetScreen()->AddObserver(this);
@@ -420,7 +420,7 @@ LoginDisplayHostImpl::~LoginDisplayHostImpl() {
}
if (!chrome::IsRunningInMash())
- ash::WmShell::Get()->delegate()->RemoveVirtualKeyboardStateObserver(this);
+ ash::WmShell::Get()->RemoveShellObserver(this);
else
NOTIMPLEMENTED();
display::Screen::GetScreen()->RemoveObserver(this);
@@ -452,7 +452,7 @@ LoginDisplayHostImpl::~LoginDisplayHostImpl() {
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, LoginDisplayHost implementation:
+// LoginDisplayHostImpl, LoginDisplayHost:
LoginDisplay* LoginDisplayHostImpl::CreateLoginDisplay(
LoginDisplay::Delegate* delegate) {
@@ -812,7 +812,7 @@ OobeUI* LoginDisplayHostImpl::GetOobeUI() const {
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, content:NotificationObserver implementation:
+// LoginDisplayHostImpl, content:NotificationObserver:
void LoginDisplayHostImpl::Observe(
int type,
@@ -888,7 +888,7 @@ void LoginDisplayHostImpl::Observe(
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, WebContentsObserver implementation:
+// LoginDisplayHostImpl, WebContentsObserver:
void LoginDisplayHostImpl::RenderProcessGone(base::TerminationStatus status) {
// Do not try to restore on shutdown
@@ -909,24 +909,21 @@ void LoginDisplayHostImpl::RenderProcessGone(base::TerminationStatus status) {
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, chromeos::SessionManagerClient::Observer
-// implementation:
+// LoginDisplayHostImpl, chromeos::SessionManagerClient::Observer:
void LoginDisplayHostImpl::EmitLoginPromptVisibleCalled() {
OnLoginPromptVisible();
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, chromeos::CrasAudioHandler::AudioObserver
-// implementation:
+// LoginDisplayHostImpl, chromeos::CrasAudioHandler::AudioObserver:
void LoginDisplayHostImpl::OnActiveOutputNodeChanged() {
TryToPlayStartupSound();
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, ash::KeyboardStateObserver:
-// implementation:
+// LoginDisplayHostImpl, ash::ShellObserver:
void LoginDisplayHostImpl::OnVirtualKeyboardStateChanged(bool activated) {
if (keyboard::KeyboardController::GetInstance()) {
@@ -944,7 +941,6 @@ void LoginDisplayHostImpl::OnVirtualKeyboardStateChanged(bool activated) {
////////////////////////////////////////////////////////////////////////////////
// LoginDisplayHostImpl, keyboard::KeyboardControllerObserver:
-// implementation:
void LoginDisplayHostImpl::OnKeyboardBoundsChanging(
const gfx::Rect& new_bounds) {
@@ -960,7 +956,7 @@ void LoginDisplayHostImpl::OnKeyboardBoundsChanging(
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, display::DisplayObserver implementation:
+// LoginDisplayHostImpl, display::DisplayObserver:
void LoginDisplayHostImpl::OnDisplayAdded(const display::Display& new_display) {
}
@@ -986,7 +982,7 @@ void LoginDisplayHostImpl::OnDisplayMetricsChanged(
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, views::WidgetRemovalsObserver implementation:
+// LoginDisplayHostImpl, views::WidgetRemovalsObserver:
void LoginDisplayHostImpl::OnWillRemoveView(views::Widget* widget,
views::View* view) {
if (view != static_cast<views::View*>(login_view_))
@@ -996,8 +992,7 @@ void LoginDisplayHostImpl::OnWillRemoveView(views::Widget* widget,
}
////////////////////////////////////////////////////////////////////////////////
-// LoginDisplayHostImpl, chrome::MultiUserWindowManager::Observer
-// implementation:
+// LoginDisplayHostImpl, chrome::MultiUserWindowManager::Observer:
void LoginDisplayHostImpl::OnUserSwitchAnimationFinished() {
ShutdownDisplayHost(false);
}
« no previous file with comments | « chrome/browser/chromeos/login/ui/login_display_host_impl.h ('k') | chrome/browser/ui/ash/chrome_shell_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698