Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: ash/common/shell_delegate.h

Issue 2134833002: ash: Move VirtualKeyboardStateObserver functionality to ShellObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/shell_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shell_delegate.h
diff --git a/ash/common/shell_delegate.h b/ash/common/shell_delegate.h
index bf4d000f2a41d73c4393fbd4eb90f2d526918800..11ffaf3c826b439043092a72b6d920c28033c104 100644
--- a/ash/common/shell_delegate.h
+++ b/ash/common/shell_delegate.h
@@ -51,15 +51,6 @@ struct ShelfItem;
class WmShelf;
class WmWindow;
-class ASH_EXPORT VirtualKeyboardStateObserver {
- public:
- // Called when keyboard is activated/deactivated.
- virtual void OnVirtualKeyboardStateChanged(bool activated) {}
-
- protected:
- virtual ~VirtualKeyboardStateObserver() {}
-};
-
// Delegate of the Shell.
class ASH_EXPORT ShellDelegate {
public:
@@ -104,15 +95,6 @@ class ASH_EXPORT ShellDelegate {
// Create a shell-specific keyboard::KeyboardUI
virtual keyboard::KeyboardUI* CreateKeyboardUI() = 0;
- // Called when virtual keyboard has been activated/deactivated.
- virtual void VirtualKeyboardActivated(bool activated) = 0;
-
- // Adds or removes virtual keyboard state observer.
- virtual void AddVirtualKeyboardStateObserver(
- VirtualKeyboardStateObserver* observer) = 0;
- virtual void RemoveVirtualKeyboardStateObserver(
- VirtualKeyboardStateObserver* observer) = 0;
-
// Opens the |url| in a new browser tab.
virtual void OpenUrl(const GURL& url) = 0;
« no previous file with comments | « no previous file | ash/common/shell_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698