Extended the iOS platform policy loader to load an additional key.

Extended the iOS platform policy loader to load an additional key.

The new "EncodedChromePolicy" key is equivalent to the existing
"ChromePolicy" key, but maps to a base64-encoded Property List instead
of an NSDictionary directly. This enables legacy MDM services to push
policy for Chrome.

BUG=348820
R=dconnelly@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259881

[Joao da Silva, 2014-03-27 11:18:16]

PTAL, thanks!

[Joao da Silva, 2014-03-27 11:18:42]

BTW, tests to come in a subsequent CL.

[Joao da Silva, 2014-03-27 12:09:16]

Now with tests. PTAL, thanks!

[dconnelly, 2014-03-27 13:14:19]

lgtm

https://codereview.chromium.org/213483004/diff/20001/components/policy/core/c...
File components/policy/core/common/policy_loader_ios.mm (right):

https://codereview.chromium.org/213483004/diff/20001/components/policy/core/c...
components/policy/core/common/policy_loader_ios.mm:115: id encodedChromePolicy =
configuration[kEncodedChromePolicyKey];
I think a warning on !(chromePolicy ^ encodedChromePolicy) would be helpful.

https://codereview.chromium.org/213483004/diff/20001/components/policy/core/c...
components/policy/core/common/policy_loader_ios.mm:134: NSLog(@"Invalid property
list in EncodedChromePolicy: %@", error);
Does !properties imply !!error? If not, maybe a different error message?

[Joao da Silva, 2014-03-27 14:05:07]

Thanks for the review!

https://codereview.chromium.org/213483004/diff/20001/components/policy/core/c...
File components/policy/core/common/policy_loader_ios.mm (right):

https://codereview.chromium.org/213483004/diff/20001/components/policy/core/c...
components/policy/core/common/policy_loader_ios.mm:115: id encodedChromePolicy =
configuration[kEncodedChromePolicyKey];
On 2014/03/27 13:14:19, dconnelly wrote:
> I think a warning on !(chromePolicy ^ encodedChromePolicy) would be helpful.

Added a warning on chromePolicy && encodedChromePolicy (if both are not set then
that's fine)

https://codereview.chromium.org/213483004/diff/20001/components/policy/core/c...
components/policy/core/common/policy_loader_ios.mm:134: NSLog(@"Invalid property
list in EncodedChromePolicy: %@", error);
On 2014/03/27 13:14:19, dconnelly wrote:
> Does !properties imply !!error? If not, maybe a different error message?

Done.

[Joao da Silva, 2014-03-27 14:05:44]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-03-27 14:05:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/213483004/40001

[commit-bot: I haz the power, 2014-03-27 14:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 14:38:10]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Joao da Silva, 2014-03-27 14:41:57]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-03-27 14:41:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/213483004/40001

[commit-bot: I haz the power, 2014-03-27 14:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 14:43:10]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[Joao da Silva, 2014-03-27 15:50:13]

Committed patchset #4 manually as r259881 (presubmit successful).