Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2134803002: [builtins] Object.prototype.toString() as TurboFan stub. (Closed)

Created:
4 years, 5 months ago by Franzi
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Object.prototype.toString() as TurboFan stub. For angular.js on Speedometer, this results in 8.96% speed up, i.e., the tests take on average 762ms with this patch, 837ms without. BUG=v8:5175 Committed: https://crrev.com/3a1296a20e9bd8a4494c453ece5e276314dfe256 Cr-Commit-Position: refs/heads/master@{#37827}

Patch Set 1 #

Patch Set 2 : First stab at toString() TurboFan stub #

Patch Set 3 : Rebase #

Patch Set 4 : Fix wrapper cases #

Patch Set 5 : Concat return value not in runtime #

Patch Set 6 : Handle JS_VALUE_TYPE #

Patch Set 7 : Extract code that handles primitives #

Patch Set 8 : Remove ToString from list of functions we identify by id #

Patch Set 9 : Defer some unlikely branches #

Patch Set 10 : Rename function #

Patch Set 11 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -11 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -1 line 0 comments Download
M src/builtins/builtins.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +248 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Franzi
Hi Toon, I rewrote ObjectProtoToString() as TurboFan stub. Please have a look. Thanks, Franzi
4 years, 5 months ago (2016-07-18 08:56:39 UTC) #14
Toon Verwaest
lgtm, very nice!
4 years, 5 months ago (2016-07-18 09:58:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134803002/190001
4 years, 5 months ago (2016-07-18 09:58:51 UTC) #19
commit-bot: I haz the power
Committed patchset #11 (id:190001)
4 years, 5 months ago (2016-07-18 10:02:39 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 10:02:41 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 10:05:25 UTC) #24
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/3a1296a20e9bd8a4494c453ece5e276314dfe256
Cr-Commit-Position: refs/heads/master@{#37827}

Powered by Google App Engine
This is Rietveld 408576698