Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: gpu/ipc/client/command_buffer_proxy_impl.h

Issue 2134793002: Remove the command buffer method glGetImageivCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge conflict. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/gles2_conform_support/egl/context.cc ('k') | gpu/ipc/client/command_buffer_proxy_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/ipc/client/command_buffer_proxy_impl.h
diff --git a/gpu/ipc/client/command_buffer_proxy_impl.h b/gpu/ipc/client/command_buffer_proxy_impl.h
index bdc7bc8fca3367a458bce764104154f21ef063fa..1c60dea1368153d705a2d4eb3ef7249f9a226a2f 100644
--- a/gpu/ipc/client/command_buffer_proxy_impl.h
+++ b/gpu/ipc/client/command_buffer_proxy_impl.h
@@ -121,7 +121,6 @@ class GPU_EXPORT CommandBufferProxyImpl
size_t height,
unsigned internal_format,
unsigned usage) override;
- int32_t GetImageGpuMemoryBufferId(unsigned image_id) override;
void SignalQuery(uint32_t query, const base::Closure& callback) override;
void SetLock(base::Lock* lock) override;
void EnsureWorkVisible() override;
@@ -294,20 +293,6 @@ class GPU_EXPORT CommandBufferProxyImpl
SwapBuffersCompletionCallback swap_buffers_completion_callback_;
UpdateVSyncParametersCallback update_vsync_parameters_completion_callback_;
- // |gpu_memory_buffer_id| will always contain a valid (not -1) id.
- // If the GpuMemoryBuffer was created through this class, then
- // |owned_gpu_memory_buffer| will also be not null.
- struct ImageInfo {
- ImageInfo();
- ~ImageInfo();
- ImageInfo(ImageInfo&& other);
- ImageInfo& operator=(ImageInfo&& other);
- int32_t gpu_memory_buffer_id = -1;
- std::unique_ptr<gfx::GpuMemoryBuffer> owned_gpu_memory_buffer;
- };
- // A map from image id to ImageInfo.
- std::map<int32_t, ImageInfo> image_gmb_map_;
-
base::WeakPtr<CommandBufferProxyImpl> weak_this_;
scoped_refptr<base::SequencedTaskRunner> callback_thread_;
« no previous file with comments | « gpu/gles2_conform_support/egl/context.cc ('k') | gpu/ipc/client/command_buffer_proxy_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698