Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2134763002:
sandwich: Fixes a bug when served from cache request are before. (Closed)
|
Created:
4 years, 5 months ago by gabadie Modified:
4 years, 5 months ago Reviewers:
pasko CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionsandwich: Fixes a bug when served from cache request are before.
Before, prefetch experiment's CSV collection was maintaining a dict
of transfered bytes per URLs as it was iterating over all resource
requests and served from memory cache URLs request would just grabe
the size from this dictionary. But we may have requests served from
memory cache before original request that filled the memory cache,
leading to a KeyError.
This CL fixes this issue by first building the dictionary by going
over resources requests, and then actually sum the bytes using this
dictionary, avoiding the KeyError.
BUG=582080
Committed: https://crrev.com/866025e8432bd4a23c221189be36696113e87c32
Cr-Commit-Position: refs/heads/master@{#404626}
Patch Set 1 #Patch Set 2 : Rebase for landing #Messages
Total messages: 17 (8 generated)
gabadie@chromium.org changed reviewers: + pasko@chromium.org
lgtm, thank you for detailed explanation!
Description was changed from ========== sandwich: Fixes a bug when served from cache request are before. Before, prefetch experiement CSV collection was maintaining a dict of transfered bytes per URLs as it was iterating over all resource requests and served from memory cache URLs request would just grabe the size from this dictionary. But we may have requests served from memory cache before original request that filled the memory cache, leading to a KeyError. This CL fixes this issue by first building the dictionary by going resources requests, and then actually sum the bytes using this dictionary, avoiding the KeyError. BUG=582080 ========== to ========== sandwich: Fixes a bug when served from cache request are before. Before, prefetch experiment's CSV collection was maintaining a dict of transfered bytes per URLs as it was iterating over all resource requests and served from memory cache URLs request would just grabe the size from this dictionary. But we may have requests served from memory cache before original request that filled the memory cache, leading to a KeyError. This CL fixes this issue by first building the dictionary by going over resources requests, and then actually sum the bytes using this dictionary, avoiding the KeyError. BUG=582080 ==========
On 2016/07/08 15:17:45, pasko wrote: > lgtm, thank you for detailed explanation! Thanks! Landing once https://codereview.chromium.org/2131973002/ is landed to rebase.
The CQ bit was checked by gabadie@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by gabadie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org Link to the patchset: https://codereview.chromium.org/2134763002/#ps20001 (title: "Rebase for landing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== sandwich: Fixes a bug when served from cache request are before. Before, prefetch experiment's CSV collection was maintaining a dict of transfered bytes per URLs as it was iterating over all resource requests and served from memory cache URLs request would just grabe the size from this dictionary. But we may have requests served from memory cache before original request that filled the memory cache, leading to a KeyError. This CL fixes this issue by first building the dictionary by going over resources requests, and then actually sum the bytes using this dictionary, avoiding the KeyError. BUG=582080 ========== to ========== sandwich: Fixes a bug when served from cache request are before. Before, prefetch experiment's CSV collection was maintaining a dict of transfered bytes per URLs as it was iterating over all resource requests and served from memory cache URLs request would just grabe the size from this dictionary. But we may have requests served from memory cache before original request that filled the memory cache, leading to a KeyError. This CL fixes this issue by first building the dictionary by going over resources requests, and then actually sum the bytes using this dictionary, avoiding the KeyError. BUG=582080 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== sandwich: Fixes a bug when served from cache request are before. Before, prefetch experiment's CSV collection was maintaining a dict of transfered bytes per URLs as it was iterating over all resource requests and served from memory cache URLs request would just grabe the size from this dictionary. But we may have requests served from memory cache before original request that filled the memory cache, leading to a KeyError. This CL fixes this issue by first building the dictionary by going over resources requests, and then actually sum the bytes using this dictionary, avoiding the KeyError. BUG=582080 ========== to ========== sandwich: Fixes a bug when served from cache request are before. Before, prefetch experiment's CSV collection was maintaining a dict of transfered bytes per URLs as it was iterating over all resource requests and served from memory cache URLs request would just grabe the size from this dictionary. But we may have requests served from memory cache before original request that filled the memory cache, leading to a KeyError. This CL fixes this issue by first building the dictionary by going over resources requests, and then actually sum the bytes using this dictionary, avoiding the KeyError. BUG=582080 Committed: https://crrev.com/866025e8432bd4a23c221189be36696113e87c32 Cr-Commit-Position: refs/heads/master@{#404626} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/866025e8432bd4a23c221189be36696113e87c32 Cr-Commit-Position: refs/heads/master@{#404626} |
